[webkit-reviews] review requested: [Bug 69343] [GTK] Initial implementation of back forward list for WebKit2 GTK+ API : [Attachment 109635] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 4 10:04:39 PDT 2011


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 69343: [GTK] Initial implementation of back forward list for WebKit2 GTK+
API
https://bugs.webkit.org/show_bug.cgi?id=69343

Attachment 109635: Patch
https://bugs.webkit.org/attachment.cgi?id=109635&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Initial impementation of bf list. The API is a bit different from webkit1. In
wk1 we have WebkitWebHistoryItem, which is a bit confusing, it made me think
there was a WebKitWebHistory object. So, I've renamed it to
WebKitWebBackForwardListItem. C API doesn't expose AddItem method, so I haven't
included it in GTK+ API for now, I've asked apple guys if there's a reason for
not exposing such a method. I've tried to not add methods present in wk1 API
that don't seem to be used, to the patch a bit smaller too, we can add them in
following patches if they are actually needed.


More information about the webkit-reviews mailing list