[webkit-reviews] review granted: [Bug 69311] Add static ClassInfo structs to classes that override JSCell::getCallData : [Attachment 109567] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 69311: Add static ClassInfo structs to classes that override
JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=69311

Attachment 109567: Patch
https://bugs.webkit.org/attachment.cgi?id=109567&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109567&action=review


> Source/JavaScriptCore/ChangeLog:9
> +	   Added ClassInfo structs to each class that defined its own
getCallData 
> +	   function but did not already have its own ClassInfo struct.	This is
a 

Are these structs used yet, or is that a task for a separate patch?

> Source/JavaScriptCore/runtime/Error.cpp:207
> +    virtual CallType getCallDataVirtual(CallData& callData)
>      {
>	   return getCallData(this, callData);
>      }

Typically we don’t want virtual functions to also have inline function
definitions. Not new in this patch and probably not a problem since we’ll be
deleting this soon.