[webkit-reviews] review requested: [Bug 69317] [CSS3 Regions] Make overflow:hidden/auto/scroll objects work in regions : [Attachment 109632] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 4 09:27:23 PDT 2011


Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 69317: [CSS3 Regions] Make overflow:hidden/auto/scroll objects work in
regions
https://bugs.webkit.org/show_bug.cgi?id=69317

Attachment 109632: Patch
https://bugs.webkit.org/attachment.cgi?id=109632&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Changes from the previous patch:

(1) Added updated results for two multicol tests that progressed, since they
relied on the buggy getClearDelta behavior before. Now that getClearDelta is
patched for writing modes, the overflow sections properly shifted below the
floats.

(2) Fixed failing tests caused by offsetFromLogicalTopOfFirstPage() bailing if
you weren't in a render flow thread. Changed it to be like it used to be, and
bail when you're not paginated.


More information about the webkit-reviews mailing list