[webkit-reviews] review denied: [Bug 69329] [WebKit2][gtk] Fix warnings while generating documentation using gtk-doc. : [Attachment 109621] Warning fix

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 69329: [WebKit2][gtk] Fix warnings while generating documentation using
gtk-doc.
https://bugs.webkit.org/show_bug.cgi?id=69329

Attachment 109621: Warning fix
https://bugs.webkit.org/attachment.cgi?id=109621&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109621&action=review


I really, really, really, really appreciate this! Please accept my humble
suggestion below.

> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:41
> + * @WEBKIT_NETWORK_ERROR_FAILED: Resource loading failed.
> + * @WEBKIT_NETWORK_ERROR_TRANSPORT: Transport protocol error.
> + * @WEBKIT_NETWORK_ERROR_UNKNOWN_PROTOCOL: Can not honor the request because
protocol is not known.
> + * @WEBKIT_NETWORK_ERROR_CANCELLED: Load request is cancelled.
> + * @WEBKIT_NETWORK_ERROR_FILE_DOES_NOT_EXIST: File does not exists error.

I think we should use a consistent phrase for all of these and avoid the use of
periods (since they aren't complete sentences):

So:
Generic load failure
Load failure due to transport error
Load failure due to unknown protocol
Load failure due to cancellation
Load failure due to missing file