[webkit-reviews] review granted: [Bug 69018] add more stack dumping methods : [Attachment 109560] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 4 07:47:00 PDT 2011

Darin Adler <darin at apple.com> has granted Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 69018: add more stack dumping methods

Attachment 109560: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109560&action=review

> Source/JavaScriptCore/wtf/Assertions.cpp:196
> -    static const int maxFrames = 32;
> +    enum { maxFrames = 32 };

As mentioned in my comment in this bug, I strongly discourage the C-style use
of enum here. Reflects FUD about C++ integer constants that is not founded.

More information about the webkit-reviews mailing list