[webkit-reviews] review denied: [Bug 69015] Web Inspector: Add support for search in script content. : [Attachment 109605] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 4 06:55:19 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 69015: Web Inspector: Add support for search in script content.
https://bugs.webkit.org/show_bug.cgi?id=69015
Attachment 109605: Patch
https://bugs.webkit.org/attachment.cgi?id=109605&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109605&action=review
> Source/WebCore/inspector/front-end/ContentProviders.js:72
> + if (!this._sortedScriptsArray) {
You should not cache this result.
> Source/WebCore/inspector/front-end/Script.js:52
> + this._source = source || "";
You should be explicit about the error and do this._source = error ? "" :
source;
More information about the webkit-reviews
mailing list