[webkit-reviews] review denied: [Bug 69234] Web Inspector: Factor out object properties popup : [Attachment 109532] Comments addressed

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 69234: Web Inspector: Factor out object properties popup
https://bugs.webkit.org/show_bug.cgi?id=69234

Attachment 109532: Comments addressed
https://bugs.webkit.org/attachment.cgi?id=109532&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109532&action=review


r- for .js + i need to apply this change. it is not clear to me whether this
regresses anything :(

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:69384
> +				       
RelativePath="..\inspector\front-end\ObjectPopoverHelper.js.js"

.js.js -> .js

> Source/WebCore/inspector/front-end/SourceFrame.js:-653
> -	   if (this._popoverHelper)

I'll need to apply the change to check whether something regresses.