[webkit-reviews] review denied: [Bug 68949] [MutationObservers] Add stub implementation of WebKitMutationObserver : [Attachment 109545] Fixed nits, got rid of MutationRecordArray

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 3 16:21:02 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has denied Adam Klein <adamk at chromium.org>'s
request for review:
Bug 68949: [MutationObservers] Add stub implementation of
WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=68949

Attachment 109545: Fixed nits, got rid of MutationRecordArray
https://bugs.webkit.org/attachment.cgi?id=109545&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109545&action=review


r- given Sam's comment.

> Source/WebCore/dom/WebKitMutationObserver.idl:39
> +	   void observe(in Node target, in WebKitMutationObserverOptions
options);

It seems like Sam want you to replace WebKitMutationObserverOptions by Object
and properly handle dictionary.


More information about the webkit-reviews mailing list