[webkit-reviews] review granted: [Bug 68974] watchlist: Make watchlist run on a bot. : [Attachment 109529] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 68974: watchlist: Make watchlist run on a bot.
https://bugs.webkit.org/show_bug.cgi?id=68974

Attachment 109529: Patch
https://bugs.webkit.org/attachment.cgi?id=109529&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109529&action=review


> Tools/Scripts/webkitpy/tool/commands/queues_unittest.py:416
> -	       "process_work_item": "MOCK: update_status: style-queue
Pass\nMOCK: release_work_item: style-queue 10000\n",
> +	       "process_work_item": "MOCK run_and_throw_if_fail: ['echo',
'--status-host=example.com', 'check-style', '--force-clean',
'--non-interactive', '--parent-command=style-queue', 10000],
cwd=/mock-checkout\nMOCK run_and_throw_if_fail: ['echo',
'--status-host=example.com', 'apply-watchlist-local', 50000],
cwd=/mock-checkout\nMOCK: update_status: style-queue Pass\nMOCK:
release_work_item: style-queue 10000\n",

When these lines get long, we tend to use heredoc comments """blah
blah
blah"""
to make it easier to read (and to see the diffs).