[webkit-reviews] review denied: [Bug 69272] [WinCairo] Switch to Release builds and activate tests on buildbot : [Attachment 109500] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 3 11:32:46 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 69272: [WinCairo] Switch to Release builds and activate tests on buildbot
https://bugs.webkit.org/show_bug.cgi?id=69272

Attachment 109500: Patch
https://bugs.webkit.org/attachment.cgi?id=109500&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109500&action=review


Since we expect this to turn the bot red, perhaps we should also remove the bot
from the set of core builders?

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:257
> +			 "name": "WinCairo Release (Build)", "type":
"BuildAndTest", "builddir": "win-cairo-release",

The "(Build)" suffix is typically only used for build-only bots. So I think you
should remove it.


More information about the webkit-reviews mailing list