[webkit-reviews] review granted: [Bug 69182] BiquadFilterNode .type attribute is not handled correctly : [Attachment 109375] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 69182: BiquadFilterNode .type attribute is not handled correctly
https://bugs.webkit.org/show_bug.cgi?id=69182

Attachment 109375: Patch
https://bugs.webkit.org/attachment.cgi?id=109375&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109375&action=review


Looks fine overall; couple of comments. r=me

> LayoutTests/webaudio/biquadfilternode-basic.html:29
> +    // FIXME: we need to expose the actual filter type constants in the IDL

Have you already filed a bug about this?

> LayoutTests/webaudio/biquadfilternode-basic.html:38
> +    for (var i = 0; i <= 7; ++i) {

FIXME for the magic constant 7.

> Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp:61
> +    m_hasJustReset = true;

Is this fix really related or should it be a separate change?