[webkit-reviews] review granted: [Bug 69262] AX: click point for AXHeadings often returns point on empty space (results in wrong context menu) : [Attachment 109492] patch

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 69262: AX: click point for AXHeadings often returns point on empty space
(results in wrong context menu)
https://bugs.webkit.org/show_bug.cgi?id=69262

Attachment 109492: patch
https://bugs.webkit.org/attachment.cgi?id=109492&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109492&action=review


> Source/WebCore/accessibility/AccessibilityObject.h:-510
> -    virtual LayoutPoint clickPoint() const;

You should mention in the ChangeLog why you had to remove the const. I presume
you did so because AccessibilityObject::children() is non-const? Could you
change AccessibilityObject::children() to be const instead?