[webkit-reviews] review denied: [Bug 13332] List marker not displayed on items with overflow : [Attachment 109195] Use special PaintPhaseListMarkers

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Konstantin Shcheglov
<scheglov at google.com>'s request for review:
Bug 13332: List marker not displayed on items with overflow
https://bugs.webkit.org/show_bug.cgi?id=13332

Attachment 109195: Use special PaintPhaseListMarkers
https://bugs.webkit.org/attachment.cgi?id=109195&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You're missing a couple of places (and I'd like to see a test for each place
I'm about to call out).

paintFloats you need to patch. Make a float with a list marker inside
somewhere.

You also missed InlineBox::paint. Make a div with display:inline-block and then
put a list inside it somewhere.

You missed RenderLayerBacking::paintIntoLayer. To test this one make a layer
with a 3d transform (translateZ(0) is sufficient I think) and put a list marker
inside it.

The fact that these places are hard to spot is a problem. You might consider
making a helper function called by these places to paint all the phases
(assuming that's possible).