[webkit-reviews] review granted: [Bug 69245] feColorMatrix saturation is not limited to range 0..1 anymore : [Attachment 109464] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 3 04:11:59 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 69245: feColorMatrix saturation is not limited to range 0..1 anymore
https://bugs.webkit.org/show_bug.cgi?id=69245

Attachment 109464: Patch
https://bugs.webkit.org/attachment.cgi?id=109464&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109464&action=review


Patch looks good, r=me.

> LayoutTests/svg/filters/feColorMatrix-values.svg:66
> +    <text y="340" x="210" style="filter:url(#satrange)">Saturate must 
</text>
> +    <text y="370" x="210" style="filter:url(#satrange)">have one
value.</text>

I don't see this text in the png. Can you remove it and make it a comment?


More information about the webkit-reviews mailing list