[webkit-reviews] review denied: [Bug 69234] Web Inspector: Factor out object properties popup : [Attachment 109434] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 3 02:05:57 PDT 2011

Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 69234: Web Inspector: Factor out object properties popup

Attachment 109434: Patch

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109434&action=review

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:45
> +    onPropertiesReceived: function(properties)

Client should override updateProperties instead.

> Source/WebCore/inspector/front-end/Popover.js:296
> +    panelElement.addEventListener("scroll", this.hidePopover.bind(this),

You should only react on the scroll events in the path to the root, right?

> Source/WebCore/inspector/front-end/Popover.js:327
> +		   var section = new

Popover.js should not depend on ObjectPropertiesSection.js since it breaks
partial front-end compilability.

> Source/WebCore/inspector/front-end/SourceFrame.js:-654
> -	       this._popoverHelper.hidePopover();

Why did this change?

More information about the webkit-reviews mailing list