[webkit-reviews] review granted: [Bug 69221] Web Inspector: restore partial front-end compilability : [Attachment 109419] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 3 00:54:08 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 69221: Web Inspector: restore partial front-end compilability
https://bugs.webkit.org/show_bug.cgi?id=69221

Attachment 109419: Patch
https://bugs.webkit.org/attachment.cgi?id=109419&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109419&action=review


> Source/WebCore/inspector/front-end/DOMAgent.js:389
> +    /** @type {Object|undefined} */

When can it become undefined?

> Source/WebCore/inspector/front-end/Object.js:71
> +	* @param {*=} eventData

Should be just {*}


More information about the webkit-reviews mailing list