[webkit-reviews] review granted: [Bug 69241] Should call checkTextOfParagraph() indirectly to make unifying spell-checking code path ease : [Attachment 109440] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 2 23:33:21 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 69241: Should call checkTextOfParagraph() indirectly to make unifying
spell-checking code path ease
https://bugs.webkit.org/show_bug.cgi?id=69241

Attachment 109440: Patch
https://bugs.webkit.org/attachment.cgi?id=109440&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109440&action=review


> Source/WebCore/ChangeLog:12
> +	   At the first step, this patch introduces an indirect wrappero to
call

Typo: wrappero

> Source/WebCore/editing/TextCheckingHelper.h:96
> +			     TextCheckingTypeMask checkingTypes,
Vector<TextCheckingResult>& results);

Nit: indentation is wrong here. TextCheckingTypeMask should be indented by
exactly 4 spaces, and should NOT be aligned with TextCheckerClient.


More information about the webkit-reviews mailing list