[webkit-reviews] review denied: [Bug 65760] CSSSelector::selectorText should use StringBuilder instead of += : [Attachment 105583] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 2 22:25:03 PDT 2011


MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 65760: CSSSelector::selectorText should use StringBuilder instead of +=
https://bugs.webkit.org/show_bug.cgi?id=65760

Attachment 105583: Patch
https://bugs.webkit.org/attachment.cgi?id=105583&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105583&action=review


> Source/WebCore/css/CSSSelector.cpp:629
>      if (CSSSelector* tagHistory = cs->tagHistory()) {

How about just to return and eliminate temporal "str" ?
Also, you can do early return by checking tagHistory != NULL.


More information about the webkit-reviews mailing list