[webkit-reviews] review granted: [Bug 69230] Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers : [Attachment 109431] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 2 17:33:24 PDT 2011


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 69230: Strength reduce Mac only Frame::searchForLabelsBeforeElement and
Frame::matchLabelsAgainstElement into callers
https://bugs.webkit.org/show_bug.cgi?id=69230

Attachment 109431: Patch
https://bugs.webkit.org/attachment.cgi?id=109431&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109431&action=review


> Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:537
> +    // FIXME: This code is mirrored in Frame.cpp. It would be nice to make
the Mac code call the platform-agnostic
> +    // code, which would require converting the NSArray of NSStrings to a
Vector of Strings somewhere along the way.

Is this comment still relevant?


More information about the webkit-reviews mailing list