[webkit-reviews] review granted: [Bug 69015] Web Inspector: Add support for backend search in script content. : [Attachment 109301] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 69015: Web Inspector: Add support for backend search in script content.
https://bugs.webkit.org/show_bug.cgi?id=69015

Attachment 109301: Patch
https://bugs.webkit.org/attachment.cgi?id=109301&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109301&action=review


> Source/WebCore/ChangeLog:3
> +	   Web Inspector: Add support for backend search in script content.

The title is a bit misleading since you have front-end pieces in this change as
well.

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:330
> +    *results = ContentSearchUtils::searchInTextByLines(query, source);

Searching in missing script should be an error.

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:351
> +    *scriptSource = source;

ditto

> Source/WebCore/inspector/front-end/Script.js:62
> +	       callback(searchMatches);

Please log potential error using console.error