[webkit-reviews] review granted: [Bug 69223] [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch. : [Attachment 109422] patch for review.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 2 10:20:38 PDT 2011


Noam Rosenthal <noam.rosenthal at nokia.com> has granted Zeno Albisser
<zeno.albisser at nokia.com>'s request for review:
Bug 69223: [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5
refactor branch.
https://bugs.webkit.org/show_bug.cgi?id=69223

Attachment 109422: patch for review.
https://bugs.webkit.org/attachment.cgi?id=109422&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109422&action=review


Patch looks good, please fix changelog before committing.

> Source/WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)

This won't get committed with OOPS in it... should be something like "No new
tests, build fix".


More information about the webkit-reviews mailing list