[webkit-reviews] review granted: [Bug 65769] New renderer for SVGRectElement : [Attachment 109287] Propsed patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 65769: New renderer for SVGRectElement
https://bugs.webkit.org/show_bug.cgi?id=65769

Attachment 109287: Propsed patch
https://bugs.webkit.org/attachment.cgi?id=109287&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109287&action=review


The patch looks great in general. Please make sure that the commented out code
doesn't cause regressions and remove it before landing!

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:740
> +

unnecessary change.

> Source/WebCore/rendering/svg/RenderSVGRect.cpp:57
> +    if (rect->hasAttribute(SVGNames::rxAttr) ||
rect->hasAttribute(SVGNames::ryAttr) || nonScalingStroke/* ||
static_cast<SVGElement*>(node())->customStyleForRenderer()->svgStyle()->shadow(
)*/) {

I don't understand the commented out code. Please add a fix me what you expect
in the future and remove that code. Add a ling to a bug report as well please.
I hope this won't cause regressions? If so you can't land this patch.

> Source/WebCore/rendering/svg/RenderSVGShape.cpp:428
> +	  
m_strokeAndMarkerBoundingBox.unite(/*outerStrokeBoundingBox()*/strokeBoundingBo
x());

Do not land dead code. Are you sure strokeBoundingBox() is doing the same like
outerStrokeBoundingBox()? I assume that the original code was added, because
strokBoundingBox() might not give the correct result at this point? Can you
clarify this first please?

> Source/WebCore/rendering/svg/RenderSVGShape.h:100
> +    /*virtual FloatRect outerStrokeBoundingBox() const
> +    {
> +	   BoundingRectStrokeStyleApplier strokeStyle(this, style());
> +	   return m_path->strokeBoundingRect(&strokeStyle);
> +    }*/

Why is this commented out? Dead code shouldn't land. Remove it please.