[webkit-reviews] review requested: [Bug 57731] [CSS 3] missing cursor support for 'none' on Windows : [Attachment 109409] Updated patch addressing latest comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 1 16:32:53 PDT 2011


Ryan <aikavanak at gmail.com> has asked  for review:
Bug 57731: [CSS 3] missing cursor support for 'none' on Windows
https://bugs.webkit.org/show_bug.cgi?id=57731

Attachment 109409: Updated patch addressing latest comments.
https://bugs.webkit.org/attachment.cgi?id=109409&action=review

------- Additional Comments from Ryan <aikavanak at gmail.com>
I've addressed the comments, including removing the const qualifiers.

This seems odd to me, considering the current general opinion on C++ best
practices is to use const whenever possible. I can understand wanting to keep
the code consistent, but in the case of consts, is it really worth it
considering the bugs const-correctness can help avoid?


More information about the webkit-reviews mailing list