[webkit-reviews] review granted: [Bug 72715] Implement AccessKeyLabel attribute. : [Attachment 117012] updated_patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 30 22:55:03 PST 2011


Alexey Proskuryakov <ap at webkit.org> has granted Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 72715: Implement AccessKeyLabel attribute.
https://bugs.webkit.org/show_bug.cgi?id=72715

Attachment 117012: updated_patch
https://bugs.webkit.org/attachment.cgi?id=117012&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117012&action=review


r=me on code changes, but test expectations don't seem right.

> LayoutTests/platform/chromium/test_expectations.txt:3831
> +// Need rebaseline on MAC

It's Mac, not MAC.

It doesn't seem like the test needs a "rebaseline", it needs to be fixed.


More information about the webkit-reviews mailing list