[webkit-reviews] review granted: [Bug 71872] [Chromium] Improve tile invalidation : [Attachment 117332] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted David Reveman
<reveman at chromium.org>'s request for review:
Bug 71872: [Chromium] Improve tile invalidation
https://bugs.webkit.org/show_bug.cgi?id=71872

Attachment 117332: Patch
https://bugs.webkit.org/attachment.cgi?id=117332&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117332&action=review


OK hurray! R=me

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:218
> +	   setNeedsDisplayRect(FloatRect(0, 0, bounds().width(),
bounds().height()));

the old code used bounds() here but should this really be contentBounds()?

feel free to fix in a follow-up if that's the case

> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:151
> +	   m_videoLayer->setNeedsDisplayRect(IntRect(0, 0,
m_videoLayer->bounds().width(), m_videoLayer->bounds().height()));

hm, shouldn't this just call setNeedsDisplay() with no args?

again this can be done in a follow-up, IMO