[webkit-reviews] review granted: [Bug 73497] Copy/paste of the same content produces increasingly nested markup : [Attachment 117294] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 73497: Copy/paste of the same content produces increasingly nested markup
https://bugs.webkit.org/show_bug.cgi?id=73497

Attachment 117294: Patch
https://bugs.webkit.org/attachment.cgi?id=117294&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117294&action=review


r=me; but the use of deprecatedNode here in this new code seems like a bad
idea.

> Source/WebCore/editing/DeleteSelectionCommand.cpp:752
> +    Node* node = m_endingPosition.deprecatedNode();

Do we have to use deprecatedNode? Can this be containerNode or anchorNode
instead?

> Source/WebCore/editing/DeleteSelectionCommand.cpp:758
> +	       node = node->parentNode();

This should be:

    node = parentNode;

> Source/WebCore/editing/DeleteSelectionCommand.cpp:763
> +	       if (node == m_endingPosition.deprecatedNode())

Do we have to use deprecatedNode? Can this be containerNode or anchorNode
instead?

> Source/WebCore/editing/DeleteSelectionCommand.cpp:767
> +	       node = m_endingPosition.deprecatedNode();

Do we have to use deprecatedNode? Can this be containerNode or anchorNode
instead?

> Source/WebCore/editing/DeleteSelectionCommand.cpp:769
> +	       node = node->parentNode();

This should be:

    node = parentNode;

> LayoutTests/editing/deleting/delete-and-cleanup.html:31
> +    confimedMarkup = node.innerHTML;

Typo here: "confimedMarkup".