[webkit-reviews] review granted: [Bug 73382] split webkit gyp files for chromium build to break the circular dependency : [Attachment 117276] update w/ review feedback
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 30 14:44:25 PST 2011
Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 73382: split webkit gyp files for chromium build to break the circular
dependency
https://bugs.webkit.org/show_bug.cgi?id=73382
Attachment 117276: update w/ review feedback
https://bugs.webkit.org/attachment.cgi?id=117276&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117276&action=review
Please make sure the chromium ews bot passes before landing.
> Source/WebKit/chromium/gyp_webkit:133
> - 'WebKit.gyp'])
> + os.path.join('All.gyp')])
Why os.path.join on a single item?
More information about the webkit-reviews
mailing list