[webkit-reviews] review granted: [Bug 72523] AX: Searching mechanism is too slow when finding the element. : [Attachment 115858] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 30 14:36:06 PST 2011


Beth Dakin <bdakin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 72523: AX: Searching mechanism is too slow when finding the element.
https://bugs.webkit.org/show_bug.cgi?id=72523

Attachment 115858: patch
https://bugs.webkit.org/attachment.cgi?id=115858&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115858&action=review


> Source/WebCore/accessibility/AccessibilityObject.cpp:373
> +    for (size_t i = startIndex; isForward ? i > endIndex : i < endIndex;
isForward ? i-- : i++) {

This line is hard to read with all of the isForward craziness. I can't think of
any obvious way to simplify it, but if you can, I encourage it.


More information about the webkit-reviews mailing list