[webkit-reviews] review denied: [Bug 72573] WebKit does not send mouse down/up/click events to ARIA tabs : [Attachment 115851] patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has denied chris fleizach <cfleizach at apple.com>'s
request for review:
Bug 72573: WebKit does not send mouse down/up/click events to ARIA tabs
https://bugs.webkit.org/show_bug.cgi?id=72573

Attachment 115851: patch
https://bugs.webkit.org/attachment.cgi?id=115851&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115851&action=review


Overall, this seems good, but since I have one issue above and there are no
ChangeLogs, I am going to r- for the time being. I will definitely r+ once you
address those things though.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:881
> +    case RadioButtonRole:

This shouldn't be necessary since this case should fall into the earlier
conditional check: if (AccessibilityObject::isARIAInput(ariaRoleAttribute())).
Right?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:882
> +    case CheckBoxRole:

Same for this one.