[webkit-reviews] review denied: [Bug 73483] [Chromium] GYP fix for Windows 2010 build : [Attachment 117262] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 73483: [Chromium] GYP fix for Windows 2010 build
https://bugs.webkit.org/show_bug.cgi?id=73483

Attachment 117262: Patch
https://bugs.webkit.org/attachment.cgi?id=117262&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117262&action=review


> Source/WebKit/chromium/ChangeLog:8
> +	   Patch by Carlos Pizano.

It would be nice to elaborate here.  Looks like there are no more files
matching the Android.cpp pattern and we added a .cpp in
WebKit/chromium/src/android/WebInputEventFactory.cpp.

> Source/WebKit/chromium/WebKit.gyp:1428
> +	   ['OS!="android"', {
> +	       'target_defaults': {
> +		   'sources/': [
> +		       ['exclude', '(^|/)android/']
> +		   ],
> +	       },
> +	   }],

I would move this up to be specific to the webkit target like the other exclude
by directory rules.  E.g., there's an OS=="android" condition that you could
make this an 'else' branch of around line 777.