[webkit-reviews] review granted: [Bug 73080] [GTK] WebAudio wav resources access and management : [Attachment 116585] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 30 13:27:02 PST 2011


Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 73080: [GTK] WebAudio wav resources access and management
https://bugs.webkit.org/show_bug.cgi?id=73080

Attachment 116585: proposed patch
https://bugs.webkit.org/attachment.cgi?id=116585&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116585&action=review


> Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp:41
> +	  
absoluteFilename.set(g_build_filename(UNINSTALLED_AUDIO_RESOURCES_DIR,
filename.get(), NULL));

Maybe it's better to pass this as an environment variable similar to what we do
for other variables like this.


More information about the webkit-reviews mailing list