[webkit-reviews] review denied: [Bug 73338] [Qt] [WK2] QQuickWebView covers QML elements that should be rendered on top. : [Attachment 117231] Fix Changelog mess

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 73338: [Qt] [WK2] QQuickWebView covers QML elements that should be rendered
on top.
https://bugs.webkit.org/show_bug.cgi?id=73338

Attachment 117231: Fix Changelog mess
https://bugs.webkit.org/attachment.cgi?id=117231&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117231&action=review


Talked to the QSG guys about this; If we do a hack, we should use the
material's virtual functions instead of the texture's.

> Source/WebKit2/ChangeLog:12
> +	   This considered to be temporary until QSGNode::UserNodeType will be
available.

This is considered to be temporary until QSGNode::UserNodeType will be
available.

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:166
> +    , m_paintNode(0)

Any chance we could use OwnPtr here?

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:223
> +    PageProxyTexture(PageProxyNode* node)  : m_node(node), m_textureId(0) {
}

Remove double spacing, new lines.

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:240
> +	   // We use transparent 1x1 texture to satisfy scene graph painter.

We use a transparent 1x1 texture to satisfy the scene graph painter.

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:288
> +    glGenTextures(1, &m_textureId);
> +    glBindTexture(GL_TEXTURE_2D, m_textureId);
> +    QImage image(1, 1, QImage::Format_ARGB32);
> +    image.fill(Qt::transparent);
> +    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, 1, 1, 0, GL_RGBA,
GL_UNSIGNED_BYTE, image.constBits());

Comment (FIXME: temporary until Qt Scenegraph support custom painting).
You can add that comment in several places, e.g. here and before the class
definitions.