[webkit-reviews] review granted: [Bug 72873] Web Inspector: [Regression] Successfully loaded XHRs are shown as canceled. : [Attachment 116513] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 72873: Web Inspector: [Regression] Successfully loaded XHRs are shown as
canceled.
https://bugs.webkit.org/show_bug.cgi?id=72873

Attachment 116513: Patch
https://bugs.webkit.org/attachment.cgi?id=116513&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116513&action=review


>>> Source/WebCore/loader/SubresourceLoader.cpp:114
>>> +}
>> 
>> Does it break other things to name this cancel() and override
ResourceLoader::cancel() ?
> 
> Looks like this can break other cancel scenarios, e.g. like here
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Sour
ce/WebCore/loader/SubresourceLoader.cpp&l=204&type=cs

Alright, thanks for checking.

I'd slightly prefer a name like "cancelIfNotFinishing", but you can feel free
to land without another review so long as it still compiles :)