[webkit-reviews] review denied: [Bug 56466] Popup menu can get stuck in closed state when GtkMenu can't grab mouse. : [Attachment 116895] updated patch rev 2

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Wajahat Siddiqui
<mdwajahatali.siddiqui at motorola.com>'s request for review:
Bug 56466: Popup menu can get stuck in closed state when GtkMenu can't grab
mouse.
https://bugs.webkit.org/show_bug.cgi?id=56466

Attachment 116895: updated patch rev 2
https://bugs.webkit.org/attachment.cgi?id=116895&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116895&action=review


> Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:114
>  
>      g_signal_handler_disconnect(m_popup->platformMenu(), unmapHandler);
>  
> -    if (!m_client)
> -	   return;
> -
>      m_client->valueChangedForPopupMenu(this, m_activeItem);

This worries me. What if the client existed before you ran the main loop, but
not after. If the client can be null before and after the main loop run you
need to check in both places. I'm not convinced that it can be null before
though...