[webkit-reviews] review denied: [Bug 70810] nameNodeListCache should be invalidated when name attribute changes/modified. : [Attachment 112321] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 30 12:20:04 PST 2011


Darin Adler <darin at apple.com> has denied Arko Saha <nghq36 at motorola.com>'s
request for review:
Bug 70810: nameNodeListCache should be invalidated when name attribute
changes/modified.
https://bugs.webkit.org/show_bug.cgi?id=70810

Attachment 112321: Patch
https://bugs.webkit.org/attachment.cgi?id=112321&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This test case only covers the <div> element. The patch will work for that
element, but not for the <a>, <applet>, <embed>, <frame>, <form>, <iframe>,
<img>, <map>, <meta>, <object>, or <param> element, for example, due to code in
those classes’ parseMappedAttribute functions that does not call through to the
base class parseMappedAttribute function.


More information about the webkit-reviews mailing list