[webkit-reviews] review granted: [Bug 73232] IndexedDB: Implement IDBIndex multientry feature : [Attachment 117204] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 30 11:57:51 PST 2011


Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 73232: IndexedDB: Implement IDBIndex multientry feature
https://bugs.webkit.org/show_bug.cgi?id=73232

Attachment 117204: Patch
https://bugs.webkit.org/attachment.cgi?id=117204&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117204&action=review


Do you have commit access?  If so, you can use 'webkit-patch land-safely' after
making the changes locally.  If not, I'll see about nominating you.

> Source/WebCore/storage/IDBLevelDBBackingStore.cpp:715
> +	   // FIXME: Add encode/decode functions for bools

Nit: Add a period to the end of the sentence.

> Source/WebCore/storage/IDBLevelDBBackingStore.cpp:728
> +	       // FIXME: Add encode/decode functions for bools

Nit: Add a period to the end of the sentence.


More information about the webkit-reviews mailing list