[webkit-reviews] review granted: [Bug 72703] ChangeLog should be able to parse annotated changelogs : [Attachment 115770] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 72703: ChangeLog should be able to parse annotated changelogs
https://bugs.webkit.org/show_bug.cgi?id=72703

Attachment 115770: Patch
https://bugs.webkit.org/attachment.cgi?id=115770&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115770&action=review


Looks good.

> Tools/Scripts/webkitpy/common/checkout/changelog.py:287
> +	   most_probable_revision = max(revisions_in_entry,
key=revisions_in_entry.__getitem__) if revisions_in_entry else None

I'm not sure I understand this?  Also, isn't there a getitem helper used for
this sort of thing?  Object.getitem orsoemthing?   Maybe I'm thinking of
operator.itemgetter?