[webkit-reviews] review denied: [Bug 72933] "Raw" pseudo selectors don't match if immediately after a child or descendant combinator : [Attachment 116481] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 30 11:34:10 PST 2011


Antti Koivisto <koivisto at iki.fi> has denied  review:
Bug 72933: "Raw" pseudo selectors don't match if immediately after a child or
descendant combinator
https://bugs.webkit.org/show_bug.cgi?id=72933

Attachment 116481: Patch
https://bugs.webkit.org/attachment.cgi?id=116481&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
I'm not sure I understand why fixing a case involving some webkit internal use
selectors is important at all. It almost certainly shouldn't be fixed by adding
an entirely new selector checker code path. Rather you'll want to setup the
selector structures so that you can use the existing code path. I don't quite
understand what is special about the universal selectors here. 

I'll set this to r- for now.


More information about the webkit-reviews mailing list