[webkit-reviews] review granted: [Bug 73472] [MutationObservers] Make WebKitMutationObserver::deliverAllMutations() tolerant of re-entrant calls : [Attachment 117228] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 30 11:10:14 PST 2011


Ojan Vafai <ojan at chromium.org> has granted Rafael Weinstein
<rafaelw at chromium.org>'s request for review:
Bug 73472: [MutationObservers] Make
WebKitMutationObserver::deliverAllMutations() tolerant of re-entrant calls
https://bugs.webkit.org/show_bug.cgi?id=73472

Attachment 117228: Patch
https://bugs.webkit.org/attachment.cgi?id=117228&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117228&action=review


> Source/WebCore/dom/WebKitMutationObserver.cpp:139
> +	   return;

Should we have an ASSERT_NOT_REACHED() before the return here? It's a bug in
the C++ code if we ever hit this, right?


More information about the webkit-reviews mailing list