[webkit-reviews] review granted: [Bug 73029] SVG Gaussian blur in 1-dimension is incorrect : [Attachment 117213] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Florin Malita
<fmalita at google.com>'s request for review:
Bug 73029: SVG Gaussian blur in 1-dimension is incorrect
https://bugs.webkit.org/show_bug.cgi?id=73029

Attachment 117213: Patch
https://bugs.webkit.org/attachment.cgi?id=117213&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117213&action=review


> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:126
> +	       ByteArray* tmp = src;
> +	       src = dst;
> +	       dst = tmp;

I think you could use std::swap<>here.

> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:134
> +	       ByteArray* tmp = src;
> +	       src = dst;
> +	       dst = tmp;

Ditto.