[webkit-reviews] review granted: [Bug 73470] Add tests for RetainPtr::adoptNS/adoptCF : [Attachment 117223] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 30 11:00:12 PST 2011
Adam Roben (:aroben) <aroben at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 73470: Add tests for RetainPtr::adoptNS/adoptCF
https://bugs.webkit.org/show_bug.cgi?id=73470
Attachment 117223: Patch
https://bugs.webkit.org/attachment.cgi?id=117223&action=review
------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117223&action=review
> Tools/ChangeLog:8
> + * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
And .vcproj plz!
> Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:39
> + EXPECT_EQ(1, CFGetRetainCount(foo.get()));
Would -retainCount be better?
More information about the webkit-reviews
mailing list