[webkit-reviews] review granted: [Bug 73399] Add adoptCF and adoptNS convenience functions to RetainPtr.h : [Attachment 117124] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 73399: Add adoptCF and adoptNS convenience functions to RetainPtr.h
https://bugs.webkit.org/show_bug.cgi?id=73399

Attachment 117124: Patch
https://bugs.webkit.org/attachment.cgi?id=117124&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117124&action=review


> Source/JavaScriptCore/wtf/RetainPtr.h:267
> +    template<typename T> inline RetainPtr<T> adoptCF(T o)
> +    {
> +	   return RetainPtr<T>(AdoptCF, o);
> +    }
> +
> +    template<typename T> inline RetainPtr<T> adoptNS(T o)
> +    {
> +	   return RetainPtr<T>(AdoptNS, o);
> +    }
> +

Please decorate these with WARN_UNUSED_RESULT.