[webkit-reviews] review granted: [Bug 73442] Web Inspector: query backend for capabilities explicitly. : [Attachment 117187] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 73442: Web Inspector: query backend for capabilities explicitly.
https://bugs.webkit.org/show_bug.cgi?id=73442

Attachment 117187: Patch
https://bugs.webkit.org/attachment.cgi?id=117187&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117187&action=review


> Source/WebCore/bindings/js/ScriptDebugServer.h:87
> +    bool causesRecompilation() { return true; }

recompilesSourcesOnStart

> Source/WebCore/bindings/js/ScriptProfiler.h:58
> +    static bool causesRecompilation() { return true; }

Same here, the name is confusing.

> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:157
> +InspectorFrontendHost.isStub = true;

This should go in the InspectorFrontendHostStub constructor or even prototype.