[webkit-reviews] review requested: [Bug 73079] Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector. : [Attachment 117174] [patch] next iteration.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 30 05:15:46 PST 2011


Ilya Tikhonovsky <loislo at chromium.org> has asked  for review:
Bug 73079: Web Inspector: chromium: I'd like to add a script for running perf
tests for WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=73079

Attachment 117174: [patch] next iteration.
https://bugs.webkit.org/attachment.cgi?id=117174&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
(In reply to comment #15)
> (From update of attachment 116910 [details])
> (In reply to comment #14)
> > > I would probably merge all of the remaining code in this file back into
port/base.py, and delete this file. That will solve your "two files with the
same name" problem and make the layering clearer, I think.
> 
> I think you missed this comment, maybe? We should delete port/test_files.py
and merge whatever code is needed into base/Port.py

done.

webkitpy/layout_test/port/test_files.py content was moved into
webkitpy/layout_test/port/base.py
the tests for test_files were moved to base_unittests.py


More information about the webkit-reviews mailing list