[webkit-reviews] review granted: [Bug 73227] REGRESSION(r101172): It made fast/dom/clone-node-style.html assert : [Attachment 116992] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 73227: REGRESSION(r101172): It made fast/dom/clone-node-style.html assert
https://bugs.webkit.org/show_bug.cgi?id=73227

Attachment 116992: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=116992&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=116992&action=review


r=me, with comments

> Source/WebCore/css/CSSMutableStyleDeclaration.h:-79
> -    CSSMutableStyleDeclaration& operator=(const
CSSMutableStyleDeclaration&);

You probably want to hide this.

> Source/WebCore/css/CSSMutableStyleDeclaration.h:80
> +    void copyPropertiesAndStrictnessFrom(const CSSMutableStyleDeclaration&);


As discussed, it might be clearer to just have copyProperties() and use the
existing accessors for transfering the strictness.