[webkit-reviews] review denied: [Bug 73323] Web Inspector: [refactoring] do not clone nodes that contain linkified URLs : [Attachment 116977] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 73323: Web Inspector: [refactoring] do not clone nodes that contain
linkified URLs
https://bugs.webkit.org/show_bug.cgi?id=73323

Attachment 116977: Patch
https://bugs.webkit.org/attachment.cgi?id=116977&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116977&action=review


> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-935
> -    if (this.styleRule.sourceURL)

Is there a reason behind the change of behavior?

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1124
> +    _updateRuleOrigin: function(text)

You don't need to update the origin. Extracting a method that would create a
DOM elements link for given section is sufficient for getting rid of the clone.