[webkit-reviews] review granted: [Bug 73104] [EFL] Remove duplicated UA information function : [Attachment 116653] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 73104: [EFL] Remove duplicated UA information function
https://bugs.webkit.org/show_bug.cgi?id=73104

Attachment 116653: Patch
https://bugs.webkit.org/attachment.cgi?id=116653&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116653&action=review


r=me

> Source/WebKit/efl/ewk/ewk_settings.cpp:80
> +    uaOsVersion = "PPC Mac OS X";

Slight nitpick: presumably CPU(X86) tells you that you were *built* on X86.  So
you could be running a PPC binary on an X86 Mac.  You could query what kind of
Mac you're on using sysctl().  hw.machine will tell you the kind of CPU.  This
is not a big deal, probably.