[webkit-reviews] review granted: [Bug 73394] Use the [Supplemental] IDL for webaudio attributes : [Attachment 117118] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 73394: Use the [Supplemental] IDL for webaudio attributes
https://bugs.webkit.org/show_bug.cgi?id=73394

Attachment 117118: Patch
https://bugs.webkit.org/attachment.cgi?id=117118&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117118&action=review


This looks great, but I'm not sure it will compile.

> Source/WebCore/WebCore.gyp/WebCore.gyp:456
> +	       # exceed OS limites.

limites => limits

> Source/WebCore/WebCore.gyp/WebCore.gyp:466
> +	       'supplemental_dependency.tmp',

Do we need to specify a directory for this file, such as the shared
intermediate directory?

> Source/WebCore/webaudio/DOMWindowWebAudio.idl:25
> +    ] DOMWindowWebAudio {

We don't need to add this file to bindings_idl_files ?

> Source/WebCore/webaudio/DOMWindowWebAudio.idl:29
> +	   attribute [JSCCustomGetter, EnabledAtRuntime]
AudioContextConstructor webkitAudioContext;
> +	   attribute AudioPannerNodeConstructor webkitAudioPannerNode;
> +	   attribute AudioProcessingEventConstructor AudioProcessingEvent;
> +	   attribute OfflineAudioCompletionEventConstructor
OfflineAudioCompletionEvent;

Do we need new C++ implementations of these functions as statics on
DOMWindowWebAudio ?