[webkit-reviews] review denied: [Bug 73079] Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector. : [Attachment 116910] [patch] next iteration.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 29 19:07:50 PST 2011


Dirk Pranke <dpranke at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 73079: Web Inspector: chromium: I'd like to add a script for running perf
tests for WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=73079

Attachment 116910: [patch] next iteration.
https://bugs.webkit.org/attachment.cgi?id=116910&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
(In reply to comment #14)
> > I would probably merge all of the remaining code in this file back into
port/base.py, and delete this file. That will solve your "two files with the
same name" problem and make the layering clearer, I think.

I think you missed this comment, maybe? We should delete port/test_files.py and
merge whatever code is needed into base/Port.py


More information about the webkit-reviews mailing list