[webkit-reviews] review granted: [Bug 52162] Implement CSS3 Images cross-fade() image function : [Attachment 115678] Fix layering violation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 29 14:38:40 PST 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 52162: Implement CSS3 Images cross-fade() image function
https://bugs.webkit.org/show_bug.cgi?id=52162

Attachment 115678: Fix layering violation
https://bugs.webkit.org/attachment.cgi?id=115678&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115678&action=review


> Source/WebCore/css/CSSCrossfadeValue.cpp:58
> +	   
> +	   if (!styleCachedImage)

I'd omit the blank line here.

> Source/WebCore/css/CSSCrossfadeValue.cpp:158
> +    UNUSED_PARAM(image);

You could just omit the parameter name instead.


More information about the webkit-reviews mailing list